Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyword argument for contract operators, clean simulation pipeline #287

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

lukem12345
Copy link
Member

Currently, when compiling a Decapode, certain chains of matrix operations are pre-multiplied into single matrices. This cuts down on the number of matrix-vector multiplications in generated simulation code.

However the pre-multiplication of matrix operators can cause issues for certain autodiff implementations.

So, this PR adds a keyword argument to gensim that controls this behavior.

@lukem12345 lukem12345 added the enhancement New feature or request label Dec 5, 2024
@lukem12345 lukem12345 self-assigned this Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 91.37931% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base (cc035d8) to head (6d7ad46).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/simulation.jl 91.37% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   69.00%   67.69%   -1.32%     
==========================================
  Files           5        5              
  Lines         655      616      -39     
==========================================
- Hits          452      417      -35     
+ Misses        203      199       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukem12345 lukem12345 marked this pull request as ready for review December 7, 2024 02:21
@lukem12345 lukem12345 changed the title Add keyword argument for contract operators Add keyword argument for contract operators, clean simulation pipeline Dec 7, 2024
@lukem12345 lukem12345 merged commit 9ef6b0d into main Dec 9, 2024
11 checks passed
@lukem12345 lukem12345 deleted the llm/no-mat-mul branch December 9, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant