-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: wip, convert from Decapodes to DecaExpr #156
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 74.51% 75.14% +0.63%
==========================================
Files 9 11 +2
Lines 1126 1167 +41
==========================================
+ Hits 839 877 +38
- Misses 287 290 +3
☔ View full report in Codecov by Sentry. |
What's the status on this? Is there code to solve this that will live in syntactic models? |
It would be nice to have a feature extension on top of the conversion to a DecaExpr further towards something that looks like the LaTeX-like body we started with. |
a9561a1
to
6e5bf7e
Compare
This branch has just been rebased to incorporate the changes from Owens intertypes branch in PR #163 . |
Tests should fail due to the afore-mentioned dependency on development branch of ACSets. Owen's intertype branch should be merged before this. |
Note that composed operators are now expanded in Decapode deconstruction. |
@lukem12345 can you approve and merge this? Since I made the PR, I can't approve it. |
@@ -4,6 +4,7 @@ authors = ["James Fairbanks", "Andrew Baas", "Evan Patterson", "Luke Morris", "G | |||
version = "0.5.0" | |||
|
|||
[deps] | |||
ACSets = "227ef7b5-1206-438b-ac65-934d6da304b8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a compat for ACSets, but CompatHelper can catch this if it's not already in main.
No description provided.