Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: wip, convert from Decapodes to DecaExpr #156

Merged
merged 9 commits into from
Nov 7, 2023
Merged

Conversation

jpfairbanks
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5db4865) 74.51% compared to head (c3d9fc5) 75.14%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   74.51%   75.14%   +0.63%     
==========================================
  Files           9       11       +2     
  Lines        1126     1167      +41     
==========================================
+ Hits          839      877      +38     
- Misses        287      290       +3     
Files Coverage Δ
src/Decapodes.jl 100.00% <ø> (ø)
src/colanguage.jl 100.00% <100.00%> (ø)
src/language.jl 89.13% <87.50%> (-0.74%) ⬇️
src/pretty.jl 90.62% <90.62%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukem12345
Copy link
Member

What's the status on this? Is there code to solve this that will live in syntactic models?

@lukem12345
Copy link
Member

It would be nice to have a feature extension on top of the conversion to a DecaExpr further towards something that looks like the LaTeX-like body we started with.

@lukem12345 lukem12345 self-assigned this Nov 2, 2023
@lukem12345 lukem12345 added the enhancement New feature or request label Nov 2, 2023
@lukem12345
Copy link
Member

This branch has just been rebased to incorporate the changes from Owens intertypes branch in PR #163 .

@lukem12345
Copy link
Member

Tests should fail due to the afore-mentioned dependency on development branch of ACSets.

Owen's intertype branch should be merged before this.

@lukem12345
Copy link
Member

Note that composed operators are now expanded in Decapode deconstruction.

@jpfairbanks
Copy link
Member Author

@lukem12345 can you approve and merge this? Since I made the PR, I can't approve it.

@lukem12345 lukem12345 self-requested a review November 7, 2023 14:29
@@ -4,6 +4,7 @@ authors = ["James Fairbanks", "Andrew Baas", "Evan Patterson", "Luke Morris", "G
version = "0.5.0"

[deps]
ACSets = "227ef7b5-1206-438b-ac65-934d6da304b8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a compat for ACSets, but CompatHelper can catch this if it's not already in main.

@lukem12345 lukem12345 merged commit 1981441 into main Nov 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants