Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dagger Instance #147
Dagger Instance #147
Changes from 5 commits
7f4b9e2
23d31ba
45aa94a
19f97dd
c55e6d5
db7f65d
000ffb1
3fe899c
f1e5acb
208f553
7c29858
71c2580
41a5ae5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should be
MatrixThunk(delayed(x->LinearMap(mcopy_lm, plus_lm, 2*V.N, V.N)*x), V.N, 2*V.N)
etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I see what you're getting at with that, I had a hard time with this one (as well as braid and delete). I think as-is will cause a typeError, since
delayed(x->LinearMap(mcopy_lm, plus_lm, 2*V.N, V.N)*x)
is not of typeThunk
.From the way it's used in the LinearMaps instance,
mcopy
returns a morphism (LinearMap object) which is then applied to other morphisms through composition. If we're keeping with that usage (applyingmcopy
by composition), I think we'll want this to return a MatrixThunk which has an identity Thunk for the LinearMapmcopy
, which can then be used as an argument in acompose
call.This acts to copy the internal LinearMap through composition.