Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #4

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Update README.md #4

merged 2 commits into from
Nov 14, 2023

Conversation

quffaro
Copy link
Member

@quffaro quffaro commented Nov 13, 2023

Made the naming convention for new packages less strict

@quffaro
Copy link
Member Author

quffaro commented Nov 13, 2023

@mehalter I was asked to make the language around new template names to be less strict.

@quffaro quffaro requested a review from mehalter November 13, 2023 19:07
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mehalter mehalter force-pushed the readme-package-name-leniency branch from 9caa00e to 555ecf1 Compare November 14, 2023 15:51
@mehalter mehalter force-pushed the readme-package-name-leniency branch from 555ecf1 to 39f47a7 Compare November 14, 2023 16:20
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (550a3d8) 100.00% compared to head (39f47a7) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mehalter mehalter merged commit a455035 into main Nov 14, 2023
9 checks passed
@mehalter mehalter deleted the readme-package-name-leniency branch November 14, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants