Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizers with vector functions #20

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Optimizers with vector functions #20

wants to merge 10 commits into from

Conversation

samuelcohen1
Copy link
Contributor

This PR includes:

  • New versions of pullback and pushforward that use plain functions instead of matrices, making them applicable to vectors of vectors. These have completely replaced the matrix versions throughout the code, including for the scalars-only case.
  • A test in Optimizers.jl which uses vector functions
  • Minor syntax improvements on the Open{Optimizer} constructor to make it more user-friendly

@jpfairbanks
Copy link
Member

@samuelcohen1 @tylerhanks should we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuelcohen1 @jpfairbanks @lukem12345