Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT-24542] added validator for openid scope #3055

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[MNT-24542] added validator for openid scope #3055

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ef07cf
[MNT-24542] added validator for openid scope
code4uuuu Nov 26, 2024
8154c74
reformatting the file
code4uuuu Nov 26, 2024
bcd61e1
reformatting the file
code4uuuu Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...fresco/repo/security/authentication/identityservice/IdentityServiceFacadeFactoryBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,6 +659,7 @@ private OAuth2TokenValidator<Jwt> createJwtTokenValidator(ProviderDetails provid
List<OAuth2TokenValidator<Jwt>> validators = new ArrayList<>();
validators.add(new JwtTimestampValidator(Duration.of(0, ChronoUnit.MILLIS)));
validators.add(new JwtIssuerValidator(providerDetails.getIssuerUri()));
validators.add(new JwtClaimValidator<String>("scope", scope -> scope!=null && scope.contains("openid")));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly create the test case for the same.

if (!config.isClientIdValidationDisabled())
{
validators.add(new JwtClaimValidator<String>("azp", config.getResource()::equals));
Expand Down
Loading