Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-2147 Drop helper_modules role #956

Merged
merged 9 commits into from
Oct 3, 2024
Merged

OPSEXP-2147 Drop helper_modules role #956

merged 9 commits into from
Oct 3, 2024
+149 −66

Conversation

gionn
Copy link
Member

@gionn gionn commented Sep 30, 2024 •
edited
Loading

OPSEXP-2147

  • Network checks playbook moved outside the role which was not really reusable
  • Created docker scenario for quick testing
  • Added into clustered scenario for proper e2e testing

@gionn gionn self-assigned this Sep 30, 2024
@gionn gionn force-pushed the OPSEXP-2147-drop-helper-modules branch from 0de8a04 to a271292 Compare September 30, 2024 13:39
@gionn gionn requested a review from alxgomz September 30, 2024 13:55
@gionn gionn force-pushed the OPSEXP-2147-drop-helper-modules branch from ea884e1 to b26d244 Compare September 30, 2024 14:23
alxgomz
alxgomz requested changes Oct 1, 2024
View reviewed changes
playbooks/prerun-network-checks.yml Outdated Show resolved Hide resolved
playbooks/prerun-network-checks.yml Outdated Show resolved Hide resolved
playbooks/prerun-network-checks.yml Show resolved Hide resolved
playbooks/prerun-network-checks.yml Outdated Show resolved Hide resolved
playbooks/prerun-network-checks.yml Outdated Show resolved Hide resolved
playbooks/prerun-network-checks.yml Show resolved Hide resolved
playbooks/prerun-network-checks.yml Outdated Show resolved Hide resolved
playbooks/prerun-network-checks.yml Outdated Show resolved Hide resolved
@gionn gionn added the ec2-test Triggers ec2 integrations tests label Oct 1, 2024
@gionn gionn requested review from alxgomz and pmacius October 2, 2024 07:56
@gionn gionn marked this pull request as ready for review October 2, 2024 07:59
pmacius
pmacius previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did't catch anything - looks good

@gionn gionn merged commit 3869adb into master Oct 3, 2024
58 checks passed
@gionn gionn deleted the OPSEXP-2147-drop-helper-modules branch October 3, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxgomz alxgomz alxgomz approved these changes

@pmacius pmacius pmacius left review comments

Assignees

@gionn gionn

Labels
ec2-test Triggers ec2 integrations tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gionn @alxgomz @pmacius