Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update utils::get_today_string format #475

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Update utils::get_today_string format #475

merged 1 commit into from
Nov 9, 2023

Conversation

arkid15r
Copy link
Contributor

@arkid15r arkid15r commented Nov 9, 2023

Purpose/Implementation Notes

Update utils::get_today_string format -- replace minute (M) with mont (m)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@arkid15r arkid15r requested a review from davidsmejia as a code owner November 9, 2023 21:52
davidsmejia
davidsmejia approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test for that

@arkid15r arkid15r merged commit 1071b5b into dev Nov 9, 2023
5 checks passed
@arkid15r arkid15r deleted the ark/fix-date-format branch November 9, 2023 23:07
@nozomione nozomione added the API label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsmejia davidsmejia davidsmejia approved these changes

Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkid15r @davidsmejia @nozomione