Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

439 - Fix the button style overwritten issue #440

Merged
merged 1 commit into from
Sep 18, 2023
Merged

439 - Fix the button style overwritten issue #440

merged 1 commit into from
Sep 18, 2023

Conversation

nozomione
Copy link
Member

@nozomione nozomione commented Sep 18, 2023 •
edited
Loading

Issue Number

Closing #439

Purpose/Implementation Notes

Fixed the button style overwritten issue.

@dvenprasad please review the latest UI here.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@nozomione nozomione marked this pull request as ready for review September 18, 2023 14:20
@nozomione nozomione self-assigned this Sep 18, 2023
@nozomione nozomione linked an issue Sep 18, 2023 that may be closed by this pull request
Fix the button style overwritten issue #439
Closed
dvenprasad
dvenprasad approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@dvenprasad dvenprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
🦌 🦌 🦌

@nozomione nozomione merged commit 2ae9bd6 into dev Sep 18, 2023
3 of 4 checks passed
@nozomione nozomione deleted the nozomione/439-fix-button-style branch September 18, 2023 18:02
@nozomione nozomione added client / front-end bug Something isn't working labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvenprasad dvenprasad dvenprasad approved these changes

@davidsmejia davidsmejia davidsmejia approved these changes

Assignees

@nozomione nozomione

Labels
bug Something isn't working client / front-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the button style overwritten issue
3 participants
@nozomione @davidsmejia @dvenprasad