Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3452 move nginx logs and static files to /var #3453

Merged
merged 2 commits into from
Nov 3, 2023
Merged

3452 move nginx logs and static files to /var #3453

merged 2 commits into from
Nov 3, 2023

Conversation

davidsmejia
Copy link
Contributor

Issue Number

#3452

Purpose/Implementation Notes

Pretty straight forward change that does 2 things.

  • Moves nginx logs from /tmp/[access / error].log to /var/log/nginx/[access / error].log
  • Moves where we serve static files from tmp/volumes_static to /var/www/volumes_static

Methods

n/a

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

n/a

Checklist

  • Lint and unit tests pass locally with my changes

Screenshots

n/a

@davidsmejia davidsmejia requested a review from arkid15r November 3, 2023 15:35
arkid15r
arkid15r approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidsmejia davidsmejia merged commit 47ce019 into dev Nov 3, 2023
16 of 17 checks passed
@davidsmejia davidsmejia deleted the davidsmejia/3452-tmp-to-var branch November 3, 2023 16:15
@davidsmejia davidsmejia mentioned this pull request Nov 6, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidsmejia @arkid15r