Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Changelog for 0.2.0 #962

Merged
merged 11 commits into from
Dec 20, 2024
Merged

Conversation

jashapiro
Copy link
Member

This is a draft of a Changelog for 0.2.0

I tried to be brief but informative, looking through all of the descriptions in the dated releases, but I may well have missed important changes worth mentioning. Please let me know if there are things you think I should add, as well as any other changes you would suggest!

When drafting, I realized that there was one inconsistently named module, celltype-glioblastoma so I also took this chance to move it and rename references to it. If we don't want to do this now, I can easily revert the commit that accomplished this. I wasn't sure whether we wanted to include the module in the release notes, as it does not yet have anything but example code, so may not really be worth including?

@jashapiro jashapiro requested a review from sjspielman December 20, 2024 16:55
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@sjspielman sjspielman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The celltype -> cell-type changes seems very reasonable to me. Left a couple initial comments but this mostly looks in place.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
- `cell-type-wilms0tumor-14`


This release also adds the following new modules developed by the Data Lab:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cell-type-consensus is also getting added with this release

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jashapiro jashapiro marked this pull request as ready for review December 20, 2024 17:51
@jashapiro jashapiro requested a review from sjspielman December 20, 2024 17:52
Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@sjspielman sjspielman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jashapiro jashapiro merged commit 5fe8dee into AlexsLemonade:main Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants