only warn if there are too many labels in simulations #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjspielman
approved these changes
Nov 19, 2024
jashapiro
added a commit
to AlexsLemonade/OpenScPCA-nf
that referenced
this pull request
Nov 19, 2024
Port changes from AlexsLemonade/OpenScPCA-analysis#901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why this didn't come up before, but it is possible that we will end up with more cell type labels than we want to simulate, and we probably shouldn't die in that case. A warning will do.
This does present some possible downstream conditions where a module might try to use a label that is not present in the data and fails in testing, but that seems like a rare case, and probably is going to create other problems for using the simulated data as well.