-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initiate hello-clusters #805
Initiate hello-clusters #805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for the start of the repo. One typo fix I saw, and the comments below (tl;dr: do add back the standard directories).
I had some interesting trouble installing at first with your directions and a slightly nonstandard renv setup, but I think the fix for that can go elsewhere.
- I didn't include the analysis template directories (plots, scratch, & results) since I don't think they are necessary for this module, which I anticipate will just have some example notebooks at the top level. Do you foresee something I don't?
I would include these, as they don't hurt at all. You can also have the notebooks save some results (multiple clustering results as a table) and plots. I think it is good to demonstrate this even in a simple module like this.
cancel-in-progress: true | ||
|
||
on: | ||
# pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is any reason not to activate this if it is ready to go.
Closes #793
This PR establishes the
hello-clusters
module:rOpenScPCA
. As notebooks get added, the README will be expanded accordingly.force=TRUE
, but I don't think I like that I did that? I imagine when there are relevant-enough changes we'll bump the package version itself andrenv::update()
maybe should be used instead?renv.lock
file. I also added an, essentially empty for now, script to run the module which will likely just be used for testing