Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GHA trigger & Dockerfiles consistent #748

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

jashapiro
Copy link
Member

closes #676

Here I added run_ workflow files to all of the action triggers, as well as excluding the Dockerfiles. I did this both for all existing actions and for the template files.

While I was in there, I also made a small change to Dockerfile examples to eliminate a warning about ENV variables that was coming up.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM

Copy link
Member

@sjspielman sjspielman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jashapiro jashapiro merged commit d6bea93 into AlexsLemonade:main Sep 4, 2024
12 checks passed
@jashapiro jashapiro deleted the 676-trigger-consistency branch September 4, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion: Module testing GHA path updates
3 participants