Update Dockerfile and docs to use CMD instead of ENTRYPOINT #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to fix problems with running in batch
sjspielman
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
One more spot, but I don't need to see again:
https://github.com/jashapiro/OpenScPCA-analysis/blob/9972a4f7c3d35cc820e55c0093402f47351fc12a/docs/ensuring-repro/docker/docker-images.md?plain=1#L106
Just kidding, this was about conda, not Docker. I just got excited by the grep result
Just kidding about kidding, I was right the first time. And it's time for me to call it a day!
sjspielman
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I am applying the changes in from #626 in
analyses/doublet-detection/Dockerfileto all of the Dockerfiles, replacingENTRYPOINTwithCMD. This seems to solve the problems we were having with proper launching and activation of conda environments inopenscpca-nf.I also updated the docs to reflect the same suggestions.