Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the main module and add a search_class attribute to Alchemy #53

Closed

Conversation

sascha-karnatz
Copy link
Contributor

  1. remove Search module
    • the main module was refrencing to a few methods in the Search module which was some kind of duplication
    • it was hard to understand, why the Search module existed in the first place, that the main module contained a few function itself
  2. add a search_class configuration to Alchemy namespace
    • Allow the configuration of an own search class and overwrite the default behavior without monkey patching

Remove the Search module im lib and moved the function into the main module. It is now less confusing.
The default config is Alchemy::PgSearch, but it is possible to change the class from outside.
@sascha-karnatz sascha-karnatz deleted the make-search-configurable branch November 7, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant