Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatpak: Update the manifest #84

Merged
merged 1 commit into from
Jul 4, 2024
Merged

flatpak: Update the manifest #84

merged 1 commit into from
Jul 4, 2024

Conversation

Kekun
Copy link
Contributor

@Kekun Kekun commented Jul 4, 2024

This makes the manifest use the SDK's master branch, updates the build rules, and explicits to build Flips' master branch.

This makes the manifest use the SDK's master branch, updates the build
rules, and explicits to build Flips' master branch.

Signed-off-by: Adrien Plazas <[email protected]>
@Alcaro
Copy link
Owner

Alcaro commented Jul 4, 2024

That removes the need to update that thing at regular intervals, which is my main objection to that file. Looks good to me.

No clue what that -DFLATPAK is supposed to do, nothing in Flips reads that (there is a slight behavior difference under Flatpak, but it's a runtime check). But I guess it's harmless.

@Alcaro Alcaro merged commit e12ef18 into Alcaro:master Jul 4, 2024
6 checks passed
@Alcaro Alcaro mentioned this pull request Jul 4, 2024
@Kekun
Copy link
Contributor Author

Kekun commented Jul 5, 2024

Regarding -DFLATPAK I initially added it in the Flatpak manifest, and you removed it in 6ae40f0. It's indeed probably useless, but because https://github.com/flathub/com.github.Alcaro.Flips/blob/master/com.github.Alcaro.Flips.json was left intact and included it, I added it back without thinking nor investigating. My mistake. I probably cargoculted it from somewhere else 4 years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants