Update CSS token per new design system theming capability #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irma-kurnia-alaska
requested review from
blackfalcon,
jason-capsule42 and
leeejune
irma-kurnia-alaska
added
the
Status: Review Needed
blackfalcon
removed
the
Status: Review Needed
blackfalcon
force-pushed
the
irmaku/#108
branch
from
425cca6 to
85f0858
Compare
|
Additional work was addressed to modernize the repo. Updating to support Node 18 and 20 as well updating an adjustment API to support the new sizing ladder versus the legacy shirt sizing. |
blackfalcon
force-pushed
the
irmaku/#108
branch
from
9759116 to
03b067a
Compare
blackfalcon
requested review from
jordanjones243
and removed request for
blackfalcon
jason-capsule42
requested changes
Nov 13, 2023
jordanjones243
requested changes
Nov 13, 2023
Changes to be committed: modified: demo/demo.md modified: demo/index.html modified: package-lock.json modified: package.json modified: src/style.scss
This commit updates the listed files to support the new Node 18-20 transitional support policy. https://auro.alaskaair.com/node-support Changes to be committed: modified: .github/settings.yml modified: .github/workflows/testPublish.yml modified: package.json
Changes to be committed: modified: package-lock.json modified: package.json
This update preserves the legacy xxxs - xxxl sizing references but updates to include the newer base 100 scale. Changes to be committed: modified: .eslintrc.js modified: demo/demo.md modified: demo/index.html modified: docs/api.md modified: src/auro-header.js modified: src/style.scss modified: test/auro-header.test.js
blackfalcon
force-pushed
the
irmaku/#108
branch
2 times, most recently
from
d70817b to
4b63b3a
Compare
This commit updates the package configs post rebase off of main. Additional changes include: 1. Installed Sass as a dev dependency 2. Added override config 3. Removed Karama dependency 4. Revert eslint custom config and add to code 5. Remove duplicated tests Also updated is the demo/index.html to address missing code comments. Changes to be committed: modified: .eslintrc.js modified: demo/index.html modified: package-lock.json modified: package.json modified: src/auro-header.js modified: test/auro-header.test.js
blackfalcon
force-pushed
the
irmaku/#108
branch
from
4b63b3a to
a065aac
Compare
jason-capsule42
approved these changes
Jan 8, 2024
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Resolves: #108
Summary:
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team