Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS token per new design system theming capability #34

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

fajar-apri-alaska
Copy link
Contributor

Alaska Airlines Pull Request

Fixes: #33

Summary:

  • Update the package dependency only, since there's no styling applied to this component.

Type of change:

Please delete options that are not relevant.

  • Revision of an existing capability

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

- update design-token & webcorestylesheet package dependency

Changes to be committed:
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style.scss
@fajar-apri-alaska fajar-apri-alaska requested a review from a team as a code owner November 8, 2023 09:46
@fajar-apri-alaska fajar-apri-alaska linked an issue Nov 8, 2023 that may be closed by this pull request
Copy link
Member

@blackfalcon blackfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update all npm dependencies and update the repo to support Node 18 || 20 per the Node support policy

https://auro.alaskaair.com/node-support

package.json Outdated Show resolved Hide resolved
src/style.scss Outdated Show resolved Hide resolved
- update node engine to 18|20

Changes to be committed:
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style.scss
@fajar-apri-alaska
Copy link
Contributor Author

I have pushed a new commit per above feedback.

@jason-capsule42 jason-capsule42 merged commit 63559a5 into main Nov 16, 2023
4 checks passed
@jason-capsule42 jason-capsule42 deleted the fajarapri/updateCSSToken/#33 branch November 16, 2023 12:23
@blackfalcon
Copy link
Member

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auro-datetime: Theming support
3 participants