fix: equal width and height for buttons using iconOnly, slim, and rounded

[arrenleung]

Alaska Airlines Pull Request

The Flight Search team is creating a counter component that utilizes an auro-button with iconOnly, slim, and rounded properties as seen in the Figma design below:

However, the rendered button from this combination of properties was wider than expected:

Resolves: #278

Summary:

This PR adds a new style (--iconOnlySlimRounded) to handle this specific use-case, correctly matching the min/max width of the button to the min/max width set by the --iconOnlySlim styling:

Type of change:

• Revision of an existing capability

Checklist:

• My update follows the CONTRIBUTING guidelines of this project
• I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Fix the width of auro-button when using iconOnly, slim, and rounded properties by introducing a new style class iconOnlySlimRounded. Update the documentation to include examples and code snippets for this new style.

Bug Fixes:

• Fix the width of auro-button when using iconOnly, slim, and rounded properties to ensure consistent dimensions.

Documentation:

• Add documentation for the new iconOnlySlimRounded style in the API documentation, including examples and code snippets.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR implements a fix for button sizing when combining iconOnly, slim, and rounded properties by introducing a new CSS class that ensures equal width and height. The implementation adds a new style class auro-button--iconOnlySlimRounded that sets specific min/max width values to match the existing --iconOnlySlim styling.

Class diagram for AuroButton with new style class

classDiagram
    class AuroButton {
        +Boolean slim
        +Boolean iconOnly
        +Boolean rounded
        +Boolean loading
        +auro-button--slim
        +auro-button--iconOnly
        +auro-button--iconOnlySlim
        +auro-button--iconOnlySlimRounded
    }
    note for AuroButton "Added auro-button--iconOnlySlimRounded for equal width and height"

Loading

File-Level Changes

Change	Details	Files
Added new CSS class for icon-only slim rounded buttons	Created new CSS class auro-button--iconOnlySlimRounded Set min-width and max-width to match slim button dimensions Added class application logic in button component	src/style.scss src/auro-button.js
Updated documentation with new button variant	Added new example section for icon-only slim rounded buttons Created new HTML example file for the button variant Updated API documentation with usage instructions	demo/api.md docs/partials/api.md apiExamples/iconOnlySlimRounded.html

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @arrenleung - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}