Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_ascii_letter #418

Merged
merged 18 commits into from
Dec 6, 2023
Merged

is_ascii_letter #418

merged 18 commits into from
Dec 6, 2023

Conversation

littlewhitecloud
Copy link
Contributor

I am lazy to write tests lol

@littlewhitecloud
Copy link
Contributor Author

Just for tests to make the pr open instead of draft, do not merge

@Akuli
Copy link
Owner

Akuli commented Dec 4, 2023

isupper() and similar functions depend on the current locale, which is nowadays a bad idea. That's why I wanted functions similar to other stuff in ascii.jou instead.

@littlewhitecloud
Copy link
Contributor Author

isupper() and similar functions depend on the current locale, which is nowadays a bad idea. That's why I wanted functions similar to other stuff in instead.ascii.jou

I am sorry I forgot that. I will rewrite it without declare

@littlewhitecloud littlewhitecloud changed the title Ascii and type.jou is_ascii_letter Dec 5, 2023
Akuli
Akuli approved these changes Dec 6, 2023
View reviewed changes
Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :)

@Akuli Akuli merged commit 87c84ae into Akuli:main Dec 6, 2023
22 checks passed
@Akuli Akuli mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuli Akuli Akuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littlewhitecloud @Akuli