Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rsyslog max message size configurable #163

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

ettanany
Copy link
Contributor

By default Rsyslog splits log messages at 8k, but journalpump has a hard-coded value of 2048, which it uses to truncate large messages that are sent to Rsyslog. This changes that so that supported message size is now configurable.

@ettanany ettanany requested review from rdunklau and mteiste December 14, 2023 08:47
@codecov-commenter
Copy link

Codecov Report

Merging #163 (4fc53a9) into master (0de7dd3) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   63.13%   63.03%   -0.10%     
==========================================
  Files          19       19              
  Lines        2083     2083              
==========================================
- Hits         1315     1313       -2     
- Misses        768      770       +2     
Files Coverage Δ
journalpump/senders/rsyslog.py 22.38% <ø> (ø)
journalpump/rsyslog.py 14.87% <0.00%> (ø)

... and 1 file with indirect coverage changes

@ettanany ettanany force-pushed the ettanany-make-max-message-size-configurable branch from 4fc53a9 to f2b3b6c Compare December 14, 2023 12:15
@ettanany ettanany changed the title Make max message size configurable Make rsyslog max message size configurable Dec 14, 2023
@rdunklau rdunklau merged commit 3e1b59c into master Dec 15, 2023
6 checks passed
@rdunklau rdunklau deleted the ettanany-make-max-message-size-configurable branch December 15, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants