feat(dashboard): add favicon.ico (#393)

Ahoo-Wang · Apr 7, 2024 · d123ab9 · d123ab9
1 parent 48dc3b6
commit d123ab9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/cosky-dashboard/src/favicon.ico b/cosky-dashboard/src/favicon.ico
diff --git a/cosky-dashboard/src/index.html b/cosky-dashboard/src/index.html
@@ -7,6 +7,7 @@
         content="High-performance, low-cost microservice governance platform. Service Discovery and Configuration Service.">
   <base href="/dashboard/">
 <!--  <base href="/">-->
+  <link rel="icon" type="image/x-icon" href="favicon.ico">
   <meta name="viewport" content="width=device-width, initial-scale=1">
 </head>
 <body>

diff --git a/...scovery/src/main/kotlin/me/ahoo/cosky/discovery/redis/ConsistencyRedisServiceDiscovery.kt b/...scovery/src/main/kotlin/me/ahoo/cosky/discovery/redis/ConsistencyRedisServiceDiscovery.kt
@@ -117,15 +117,13 @@ class ConsistencyRedisServiceDiscovery(
         require(instanceId.isNotBlank()) { "instanceId must not be blank!" }
         val namespacedServiceId = NamespacedServiceId(namespace, serviceId)
         val instancesMono = serviceMapInstances[namespacedServiceId]
-        return if (instancesMono == null) {
-            delegate.getInstance(namespace, serviceId, instanceId)
-        } else {
-            instancesMono
-                .flatMapIterable(Function.identity())
-                .switchIfEmpty(delegate.getInstance(namespace, serviceId, instanceId))
-                .filter { it.instanceId == instanceId }
-                .next()
-        }
+            ?: return delegate.getInstance(namespace, serviceId, instanceId)
+
+        return instancesMono
+            .flatMapIterable(Function.identity())
+            .switchIfEmpty(delegate.getInstance(namespace, serviceId, instanceId))
+            .filter { it.instanceId == instanceId }
+            .next()
     }
 
     override fun getInstance(namespace: String, serviceId: String, instanceId: String): Mono<ServiceInstance> {