-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Docker Development Environment #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elds - Updated Prisma schema models and fields to follow lowercase and snake_case naming convention. - Applied `@map` directive for fields to convert camelCase to snake_case (e.g., `createdAt` -> `created_at`). - Applied `@@map` directive for models to enforce lowercase table names (e.g., `Annotations` -> `annotations`).
- Move entrypoint script to scripts directory - Remove production build steps - Keep development dependencies for hot-reloading - Add nodemon and ts-node for development server
- Add OpenSSL installation for Prisma client - Use development-specific entrypoint script - Remove multi-stage build process - Configure for hot-reloading development
- Add volume mounts for hot-reloading - Configure environment variables for development - Update service ports and dependencies - Add API URL for frontend communication
- Add PostgreSQL readiness check - Configure Prisma migration handling - Set up development environment variables - Implement proper startup sequence
- Create minimal startup configuration - Remove unnecessary database checks - Optimize for frontend development - Enable proper command execution
- Create Users table with authentication fields - Add Categories table for image organization - Set up Images table with metadata - Implement Annotations table with relationships - Add foreign key constraints and indexes
- Configure workspace for monorepo structure - Add shared development dependencies - Set up root-level scripts - Define workspace packages for api and app
- Add Express and TypeScript dependencies - Configure Prisma ORM and types - Set up development scripts with ts-node-dev - Add type checking and build scripts
- Add React and TypeScript dependencies - Configure development server scripts - Add testing and build configuration - Include necessary type definitions
- Configure server to listen on all interfaces (0.0.0.0) - Add fallback port 5000 for development - Improve logging for container startup
Ahmed3151
approved these changes
Dec 3, 2024
justFadel19
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UR him :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure Docker Development Environment
Description
This PR sets up a comprehensive Docker development environment for the HIAS project, enabling hot-reloading, proper service isolation, and streamlined development workflow.
Changes
Docker Configuration
Environment Setup
Development Workflow
File Changes
Dockerfile.api
: Optimize for development with hot-reloadingDockerfile.app
: Configure React development environmentdocker-compose.yml
: Set up development services and volumesscripts/docker-entrypoint.sh
: Add API service startup scriptscripts/docker-entrypoint-app.sh
: Add React app startup scriptpackage.json
: Configure workspace and dependenciesapi/package.json
: Set up API development scriptsapp/package.json
: Configure React development environmentTesting
Notes
Security Considerations
Next Steps
Related Issues
Closes #35