Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.5.0 framework #3838

Merged
merged 4 commits into from
Nov 20, 2024
Merged

4.5.0 framework #3838

merged 4 commits into from
Nov 20, 2024

Conversation

Suri539
Copy link
Collaborator

@Suri539 Suri539 commented Nov 20, 2024

No description provided.

@@ -43,10 +43,6 @@
<pt/>
<pd/>
</plentry>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里删掉是因为 bp 和其他框架用的都是另外一个方法,为了方便后面维护就做了一下清理

}</codeblock>
<codeblock props="flutter" outputclass="language-dart">@JsonSerializable(explicitToJson: true, includeIfNull: false)
class MediaRecorderConfiguration {
/// @nodoc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 nodoc 是不是删掉比较好

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,贴⭕️的时候漏删了,我删一下

@@ -233,49 +272,49 @@ struct FMediaRecorderConfiguration
<pt>recorderInfoUpdateInterval</pt>
<pd>录制信息更新间隔,单位为毫秒,取值范围为 [1000,10000]。SDK 会根据该值的设置触发 <xref keyref="onRecorderInfoUpdated" /> 回调,报告更新后的录制信息。</pd>
</plentry>
<plentry>
<plentry props="cpp apple android unity flutter rn electron cs unreal">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是不是可以不用动,基本上就是除了 bp 之外的所有平台。bp 本身 ditamap 里就没有放这个方法,所以不会有问题。后面 bp 如果要加的话,直接在 map 和 key 里加一下就可以,这里就不需要再弄了

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鸿蒙也有这个方法,而且加了 map,但是目前没有这几个参数,所以还是得把它 props 出去

<pt>channel_num</pt>
<pd>录制音频的声道数:
<ul>
<li>1: 单声道</li>
<li>2: 双声道</li>
</ul>
<ph props="cpp apple framework">该参数仅在 调用 <xref keyref="createMediaRecorder"/> 且将 <apiname keyref="RecorderStreamInfo"/> 中的 <parmname>type</parmname>设置为 <ph keyref="PREVIEW" /> 时需要传入。</ph>
<ph props="cpp apple unity flutter rn electron cs unreal">该参数仅在 调用 <xref keyref="createMediaRecorder"/> 且将 <apiname keyref="RecorderStreamInfo"/> 中的 <parmname>type</parmname>设置为 <ph keyref="PREVIEW" /> 时需要传入。</ph>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里“在”后面多了一个空格

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

<ph props="android">该参数仅在 调用 <xref keyref="createMediaRecorder"/> 且将 <apiname keyref="RecorderStreamInfo"/> 的 <parmname>recorderStreamType</parmname> 为 0 时需要传入。</ph>
</pd>
</plentry>
<plentry>
<plentry props="cpp apple android unity flutter rn electron cs unreal">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter 这个参数是 channelNum

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Suri539 Suri539 merged commit 7e8bc4c into release/rtc-ng/4.5.0-framework Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants