Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shipei #3836

Merged
merged 3 commits into from
Nov 20, 2024
Merged

shipei #3836

merged 3 commits into from
Nov 20, 2024

Conversation

Nero-Hu
Copy link
Collaborator

@Nero-Hu Nero-Hu commented Nov 20, 2024

No description provided.

@@ -87,7 +87,7 @@ struct FAudioTrackConfig
</ul>
</pd>
</plentry>
<plentry>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setExternalRemoteEglContext 这个方法 cm 在分工页面标记了 bp 没有,overview 和 relations 的 props 需要处理下

@@ -528,7 +528,7 @@ class ExternalVideoFrame {
<pt props="ios mac">time</pt>
<pd>传入的视频帧的时间戳,以毫秒为单位。不正确的时间戳会导致丢帧或者音视频不同步。</pd>
</plentry>
<plentry props="apple cpp" conkeyref="VideoFrame/colorspace">
<plentry props="apple cpp" conkeyref="VideoFrame/colorspace" props="cpp apple unreal unity cs flutter rn electron">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前面的 props 忘记删掉了

@Nero-Hu Nero-Hu merged commit 53ffe6b into release/rtc-ng/4.5.0-framework Nov 20, 2024
4 checks passed
@Nero-Hu Nero-Hu deleted the 4.5.0-rnelectron branch November 20, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants