4.5.0 j #3803
Merged
4.5.0 j #3803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <!DOCTYPE reference PUBLIC "-//OASIS//DTD DITA Reference//EN" "reference.dtd"> | ||
| <reference id="api_irtcengine_setexternalremoteeglcontext"> | ||
| <title><ph keyref="setExternalRemoteEglContext"/></title> | ||
| <shortdesc id="short"><ph id="shortdesc">设置远端视频流渲染的 EGL 环境上下文。</ph></shortdesc> |
There was a problem hiding this comment.
“远端视频流渲染”该如何理解？意思是说自采集的外部视频流在本地渲染时的 EGL 上下文么？
There was a problem hiding this comment.
这个方法和自采集其实没有关系，主要是自渲染
我理解指的是：在本地渲染从远端接收的视频流时，所使用的 EGL 上下文
There was a problem hiding this comment.
哦那为了避免歧义，是不是可以改为：设置远端视频流在本地渲染时的 xxx 上下文。
There was a problem hiding this comment.
这个要么保持原状吧，两次评审会上没人提问题，刚和开发确认了下他回复也不是很明朗。
| private long timestampNs; | ||
| private ColorSpace colorSpace; | ||
| private SourceType sourceType; | ||
| private float sampleAspectRatio; | ||
|
|
||
| private AlphaStitchMode alphaStitchMode = AlphaStitchMode.ALPHA_NO_STITCH; |
There was a problem hiding this comment.
原型改了，alphaStitchMode 增加了枚举类，不再是 int 了，帮忙在下面成员参数那里改一下呗
There was a problem hiding this comment.
改了但没完全改，貌似只有这个VideoFrame的原型里改了
枚举类原型定义里没有：
AgoraVideoFrame里也还是int：
你看要不要确认下先
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.