Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.4.0 bugfix 0905 #3772
4.4.0 bugfix 0905 #3772
Changes from 6 commits
256eadc
64f813e
b59356e
2980741
9be5811
2026116
5585e4e
5afb473
28b67c1
baf19a9
0e9eb4d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个内容是不是更适合放到调用限制里;可以考虑把这俩观测位置对应的回调写出来,可能更好理解
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
之前跟研发确认过,这个方法跟 oncapture那些回调 还有 registervideoframeobserver 没有关系
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
大部分写枚举的时候不用加 codeph,直接写 ph 就行了,目前比较多的是在 true/false 那里加 codeph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
但是这个其实是要加代码格式的。。。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
别的平台我不太确定,但是 Android 平台不太适合这样写,因为如果是一个回调方法,一般不能直接传递参数来设置返回值,(除非你定义变量然后再额外写一个方法去获取视频模式的常量)所以写 getVideoFrameProcessMode(1) 不太对,应该在实现该方法时直接返回期望的处理模式。我扒了一下 Android 的示例代码,里面也是直接写的处理模式。