4.4.0 electronplusrn #3739
Merged
4.4.0 electronplusrn #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suri539
reviewed
Aug 15, 2024
| <codeblock props="unity cs" outputclass="language-csharp">public virtual void OnExtensionEventWithContext(ExtensionContext context, string key, string value){ }</codeblock> | ||
| <codeblock props="rn" outputclass="language-typescript"> onExtensionStarted?(provider: string, extension: string): void;</codeblock> | ||
| <codeblock props="electron" outputclass="language-typescript">onExtensionStartedWithContext?(context: ExtensionContext): void;</codeblock> | ||
| <codeblock props="unity cs" outputclass="language-csharp">public virtual void OnExtensionEventWithContext(ExtensionContext context, string key, string value){ }</codeblock> |
There was a problem hiding this comment.
不该在分支间横跳，然后引入冲突解决的时候引入了冗余的 😭
Suri539
reviewed
Aug 15, 2024
| @@ -717,7 +717,7 @@ class VideoFrame { | |||
| <pt>textureId</pt> | |||
| <pd>该参数仅适用于 Texture 格式的视频数据。Texture ID。</pd> | |||
| </plentry> | |||
| <plentry props="cpp" id="d3d"> | |||
| <plentry props="cpp"> | |||
There was a problem hiding this comment.
这里的 props 应该也要加上 unreal bp unity electron flutter
There was a problem hiding this comment.
electron 和 flutter没有这个成员，我把 unreal bp 加上先
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.