Create custom-video-source.md #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinyuagora
commented
May 18, 2023
jinyuagora
commented
May 18, 2023
markdown/RTC 4.x/custom video source/ custom_video_source_windows_ng.md
Outdated
Show resolved
Hide resolved
jinyuagora
commented
May 18, 2023
markdown/RTC 4.x/custom video source/ custom_video_source_windows_ng.md
Outdated
Show resolved
Hide resolved
xgfd3
reviewed
May 22, 2023
markdown/RTC 4.x/custom video source/ custom_video_source_windows_ng.md
Outdated
Show resolved
Hide resolved
markdown/RTC 4.x/custom video source/ custom_video_source_windows_ng.md
Outdated
Show resolved
Hide resolved
kelzr
reviewed
May 29, 2023
markdown/RTC 4.x/custom video source/ custom_video_source_windows_ng.md
Outdated
Show resolved
Hide resolved
| m_trackConnections[trackIndex].channelId = m_strChannel.c_str(); | ||
| m_trackConnections[trackIndex].localUid = uid; | ||
| m_trackEventHandlers[trackIndex].SetId(trackIndex + 1); | ||
| m_trackEventHandlers[trackIndex].SetMsgReceiver(m_hWnd); |
There was a problem hiding this comment.
95～100行是不是没必要出现在文档里。去掉这块代码，应该也不影响核心 API 调用的展示。
There was a problem hiding this comment.
这个其实是许纯震在review的时候提建议加上，因为下文 joinChannelEx 传参的时候有用到，有这几行代码会更清晰些
int ret = m_rtcEngine->joinChannelEx(APP_TOKEN, m_trackConnections[trackIndex], mediaOptions, &m_trackEventHandlers[trackIndex]);
markdown/RTC 4.x/custom video source/ custom_video_source_windows_ng.md
Outdated
Show resolved
Hide resolved
|
|
||
| 参考下图调用时序，在你的 app 中实现自定义视频采集： | ||
|
|
||
|  |
There was a problem hiding this comment.
这个图里有一点纠结的地方。多频道的 API 调用方式有两种：
- 仅调用 joinChannelEx 加入多个频道。
- 调用 joinChannel 加入主频道，再调用 joinChannelEx 加入多个频道。
但是在这个时序图里，仅展示第一种方式。而纠结的地方在于，GitHub 示例项目的代码逻辑用的是第二种。在 Multixxxx.cpp 文件里，第 94 行是加入主频道，第 164 行是加入多频道。
所以建议在“加入多频道”这条箭头上写“joinChannelEx“，箭头下写”或 joinChannel 与 joinChannelEx 结合使用“.
markdown/RTC 4.x/custom video source/ custom_video_source_windows_ng.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.