[MC] 语聊房 Guide 评审 #2884
Open
[MC] 语聊房 Guide 评审 #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengyaxi
reviewed
Apr 10, 2023
| metaChatScene.enableVideoDisplay("1", true); | ||
| // 将媒体播放器 onFrame 回调视频帧推送至指定的视频显示屏上 | ||
| metaChatScene.pushVideoFrameToDisplay("1", frame); | ||
| ``` |
There was a problem hiding this comment.
示例代码是不是需要补一下从 onFrame 里拿到 frame 的逻辑
| spatialAudioEngine.muteLocalAudioStream(false); | ||
| // ILocalSpatialAudioEngine 设置恢复订阅所有远端音频流 | ||
| spatialAudioEngine.muteAllRemoteAudioStreams(false); | ||
| ``` |
There was a problem hiding this comment.
考虑补充一下时序图里 7、8 的逻辑？感觉至少步骤 8 需要补充一下，因为加入频道后默认订阅所有远端用户，必须先把 mutexxx 方法设为 true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs-preprod.agora.io/cn/metachat/metachat_dress_face_customization_android?platform=All%20Platforms
三篇 Guide 评审：