RTM Webdemo is invalid #1448 #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -70,6 +70,6 @@ Run the sample project according to the following steps: | |||
|
|
|||
|  | |||
|
|
|||
| Now you can experience the <Vg k="MESS" />. You can also use the [Agora <Vg k="MESS" /> Web sample app](https://webdemo.agora.io/agora-web-showcase/examples/Agora-Signaling-Tutorial-Web/) to interact with your device. Ensure that you enter the same App ID, channel name, and <Vg k="MESS" /> token in the Agora <Vg k="MESS" /> Web sample app. | |||
| Now you can experience the <Vg k="MESS" />. You can also use the [Agora <Vg k="MESS" /> Web sample app](https://github.com/AgoraIO/signaling-sdk-samples-web) to interact with your device. Ensure that you enter the same App ID, channel name, and <Vg k="MESS" /> token in the Agora <Vg k="MESS" /> Web sample app. | |||
There was a problem hiding this comment.
Not quite, this is for Signaling 2.x. You can find the web demo here: https://webdemo.agora.io/agora-web-showcase/examples/Agora-RTM-Tutorial-Web/, the code is https://github.com/AgoraIO/RTM/tree/master/Agora-RTM-Tutorial-Web. Can you update please.
There was a problem hiding this comment.
@nirm2009 please implement the change requested by Iain
billy-the-fish
previously requested changes
Sep 11, 2023
nirm2009
requested review from
billy-the-fish,
agora-websdk-builder,
saudsami and
atovpeko
and removed request for
billy-the-fish,
agora-websdk-builder and
saudsami
saudsami
approved these changes
Dec 7, 2023
nirm2009
dismissed
billy-the-fish’s stale review
Completed the requested changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.