-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling qelectron tests and making qelectron opt-in only #1916
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1916 +/- ##
===========================================
- Coverage 84.53% 84.52% -0.01%
===========================================
Files 295 295
Lines 14471 14488 +17
Branches 195 195
===========================================
+ Hits 12233 12246 +13
- Misses 2104 2108 +4
Partials 134 134
|
The diff coverage is low because the functions that have been moved to another place didn't already have tests in place. |
@Andrew-S-Rosen I think once this PR gets merged, it should unblock you in the sense that we won't have a numpy dependency for covalent. The only thing needed when installing covalent would be to have an environment variable set i.e. Simple install command to install the pre-release without numpy dependency once this PR gets merged: COVALENT_DISABLE_QELECTRON=1 pip install --pre covalent |
Brilliant, thank you! |
To make it further easier, now qelectrons (and its dependencies) are an opt-in only feature (instead of opt-out). In case its installation is required by someone, they will be able to install it using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @kessler-frost
This PR makes the following changes:
tests
github workflowpip install covalent[quantum]
since it might be blocking some users from upgrading certain versions of dependencies even if they do not require their parent deps in their workflowsResolves #1877
Resolves #1912
Resolves #1907