Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing failing tests #1888

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Fixing failing tests #1888

merged 3 commits into from
Jan 5, 2024

Conversation

kessler-frost
Copy link
Member

@kessler-frost kessler-frost commented Dec 14, 2023

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@kessler-frost kessler-frost changed the title fixing tests Fixing failing tests Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d94bdaf) 84.43% compared to head (86ebf08) 84.50%.
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1888      +/-   ##
===========================================
+ Coverage    84.43%   84.50%   +0.06%     
===========================================
  Files          294      295       +1     
  Lines        14389    14472      +83     
  Branches       195      195              
===========================================
+ Hits         12149    12229      +80     
- Misses        2106     2109       +3     
  Partials       134      134              
Flag Coverage Δ
Dispatcher 92.33% <ø> (ø)
Functional_Tests 51.42% <63.82%> (+0.09%) ⬆️
SDK 79.51% <95.74%> (+0.20%) ⬆️
UI_Backend 84.73% <ø> (ø)
UI_Frontend 73.35% <ø> (ø)

@kessler-frost kessler-frost marked this pull request as ready for review January 5, 2024 06:01
@kessler-frost kessler-frost requested a review from a team as a code owner January 5, 2024 06:01
@cjao cjao merged commit 3e755ce into develop Jan 5, 2024
14 checks passed
@cjao cjao deleted the fixing-failing-tests branch January 5, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants