Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of asset uploads during dispatch (2/2): consolidate hooks #1880

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

cjao
Copy link
Contributor

@cjao cjao commented Dec 8, 2023

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

This builds on #1879 .

Closes #1882

@cjao cjao changed the title Reduce the number of assets to upload during dispatch (2/2) Reduce the number of asset uploads during dispatch (2/2): consolidate hooks Dec 8, 2023
@cjao cjao force-pushed the slim-asset-uploads-2 branch 11 times, most recently from c43c6c0 to 2201cbc Compare December 9, 2023 21:04
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #1880 (4a707eb) into develop (a6a6999) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1880      +/-   ##
===========================================
- Coverage    84.48%   84.43%   -0.06%     
===========================================
  Files          294      294              
  Lines        14435    14389      -46     
  Branches       195      195              
===========================================
- Hits         12196    12149      -47     
- Misses        2105     2106       +1     
  Partials       134      134              
Flag Coverage Δ
Dispatcher 92.33% <100.00%> (-0.04%) ⬇️
Functional_Tests 51.32% <75.00%> (+0.10%) ⬆️
SDK 79.31% <94.25%> (-0.14%) ⬇️
UI_Backend 84.73% <100.00%> (-0.24%) ⬇️
UI_Frontend 73.35% <ø> (ø)

@cjao cjao force-pushed the slim-asset-uploads-2 branch 2 times, most recently from 8be1ca6 to 0e097f6 Compare December 10, 2023 17:25
@cjao cjao marked this pull request as ready for review December 10, 2023 17:57
@cjao cjao requested a review from a team as a code owner December 10, 2023 17:57
@FyzHsn FyzHsn merged commit 60b09e1 into develop Dec 11, 2023
14 checks passed
@FyzHsn FyzHsn deleted the slim-asset-uploads-2 branch December 11, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce asset uploads during dispatch (2/2): consolidate hooks attributes
2 participants