-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Module Dependencies feature #1876
Conversation
kessler-frost
commented
Dec 6, 2023
•
edited
Loading
edited
- I have added the tests to cover my changes.
- I have updated the documentation and CHANGELOG accordingly.
- I have read the CONTRIBUTING document.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1876 +/- ##
===========================================
+ Coverage 84.43% 84.88% +0.45%
===========================================
Files 294 181 -113
Lines 14389 11184 -3205
Branches 195 0 -195
===========================================
- Hits 12149 9494 -2655
+ Misses 2106 1690 -416
+ Partials 134 0 -134
*This pull request uses carry forward flags. Click here to find out more. |
@kessler-frost reminder on the usual list of docs changes for this as well along with this PR CC: @sriranjanivenkatesan once the docs are up, please keep a tab to update it |
One thing to note here is that DepsModule are kind of a fake traditional “deps” in the sense that we don’t require them to be passed to the server as cloudpickle takes care of serializing the module when the serialization of the function happens. |
One drawback of this is that there we won't be recording the name of the module in the dispatcher server. @santoshkumarradha it's a UX question as in do we want to have a record or not? This is mostly an additive change and can be taken care of in a separate PR as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX is gtg 🤘
Thanks @kessler-frost , the only reason would be to metadata add it in and error propagation, but lack of proper pickling should already through that error from cloud pickle side, so we are good on that front. We can backlog a PR for storing the metadata about moduledeps later this is gtg :). |