Remove duplicate boto3 requirement
#1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a boto3 requirement in requirements.txt and in tests/requirements.txt. This will eventually lead to some confusion because it's prone to get out of sync. It is a core dependency, so I kept it in requirements.txt.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1875 +/- ##
========================================
Coverage 84.44% 84.44%
========================================
Files 294 294
Lines 14396 14396
Branches 195 195
========================================
Hits 12156 12156
Misses 2106 2106
Partials 134 134
|
kessler-frost
approved these changes
Dec 6, 2023
santoshkumarradha
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a boto3 requirement in requirements.txt and in tests/requirements.txt. This will eventually lead to some confusion because it's prone to get out of sync. It is a core dependency, so I kept it in requirements.txt.