Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for cloudpickle>=3.0.0 #1873

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Allow for cloudpickle>=3.0.0 #1873

merged 3 commits into from
Dec 7, 2023

Conversation

Andrew-S-Rosen
Copy link
Contributor

@Andrew-S-Rosen Andrew-S-Rosen commented Dec 4, 2023 •
edited
Loading

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@Andrew-S-Rosen Andrew-S-Rosen requested a review from a team as a code owner December 4, 2023 20:35
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Merging #1873 (6671812) into develop (04efb9d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1873   +/-   ##
========================================
  Coverage    84.44%   84.44%           
========================================
  Files          294      294           
  Lines        14396    14396           
  Branches       195      195           
========================================
  Hits         12156    12156           
  Misses        2106     2106           
  Partials       134      134
Flag Coverage Δ
Dispatcher 92.27% <ø> (ø)
Functional_Tests 51.27% <ø> (ø)
SDK 79.34% <ø> (ø)
UI_Backend 85.07% <ø> (ø)
UI_Frontend 73.35% <ø> (ø)

@Andrew-S-Rosen Andrew-S-Rosen changed the title [Not for merge] Testing behavior of cloudpickle 3.0.0 Support cloudpickle==3.0.0 Dec 4, 2023
@santoshkumarradha
Copy link
Member

yay thanks for this !

@kessler-frost , can you add the review in your plate please? 🙏

@Andrew-S-Rosen Andrew-S-Rosen changed the title Support cloudpickle==3.0.0 Allow for cloudpickle>=3.0.0 Dec 7, 2023
kessler-frost
kessler-frost approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@kessler-frost kessler-frost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Andrew-S-Rosen !

@santoshkumarradha santoshkumarradha merged commit c78a1d8 into AgnostiqHQ:develop Dec 7, 2023
14 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the patch-3 branch December 7, 2023 07:42
@cjao cjao mentioned this pull request Jan 3, 2024
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santoshkumarradha santoshkumarradha santoshkumarradha approved these changes

@kessler-frost kessler-frost kessler-frost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andrew-S-Rosen @santoshkumarradha @kessler-frost