Memory improvements (2/3): Migrate core Covalent to new data access layer #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds on #1728 This PR migrates the core Covalent server from the in-memory Result object to the DB-backed All functional tests now pass. |
3 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1729 +/- ##
===========================================
+ Coverage 80.17% 83.69% +3.51%
===========================================
Files 232 285 +53
Lines 10239 13460 +3221
Branches 193 193
===========================================
+ Hits 8209 11265 +3056
- Misses 1897 2062 +165
Partials 133 133
|
cjao
force-pushed
the
memory-improvements-pr-2
branch
6 times, most recently
from
66abf41
to
975f01a
Compare
3 tasks
cjao
force-pushed
the
memory-improvements-pr-2
branch
from
c980139
to
ec600d5
Compare
cjao
force-pushed
the
memory-improvements-pr-2
branch
from
ec600d5
to
67c0fa5
Compare
Introduce temporary implementations of `update._node` and `update.lattice_data`. These will be removed once core covalent is transitioned to the new DAL.
Change abs imports to rel imports. Needed to please pip-missing-reqs.
- Improve type hints
This reverts commit a3ab70b.
This reverts commit 388df38236ebec7555ec7e83ffc1834427b46650.
Make API endpoints restful Cancel all dispatches upon shutdown
…lent into memory-improvements-pr-2
cjao
commented
Oct 19, 2023
kessler-frost
approved these changes
Oct 19, 2023
wjcunningham7
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/AgnostiqHQ/covalent-staging/issues/708