[Bug Fix]: Resolves Internal Server Error Triggered by Testset Removal in Evaluation Page #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aybruhm
changed the title
|
@bekossy could you help run prettier, commit and push? Thank you. |
MohammedMaaz
suggested changes
Dec 11, 2023
agenta-web/src/components/TestSetTable/ConfirmTestsetDeleteModal.tsx
Outdated
Show resolved
Hide resolved
MohammedMaaz
approved these changes
Dec 12, 2023
|
@aybruhm could this create a conflict with the default testsets ? |
No, it will not. |
aakrem
approved these changes
Dec 17, 2023
There was a problem hiding this comment.
- I would also give the option to delete the corresponding evaluations.
- The modal text should be improved to better mention that the evaluation will be referenced to an empty testset instead of dummy.
Approving for now. Please consider improving these two points.
|
getting internal server error when deleting the testset |
|
closing this as, as agreed, we want to prevent deleting a testset instead of creating dummy one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR achieves the following:
Related Issue
Closes #863 x #1005