-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Fix]: Resolves Internal Server Error Triggered by Testset Removal in Evaluation Page #986
Conversation
@bekossy could you help run prettier, commit and push? Thank you. |
agenta-web/src/components/TestSetTable/ConfirmTestsetDeleteModal.tsx
Outdated
Show resolved
Hide resolved
@aybruhm could this create a conflict with the default testsets ? |
No, it will not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I would also give the option to delete the corresponding evaluations.
- The modal text should be improved to better mention that the evaluation will be referenced to an empty testset instead of dummy.
Approving for now. Please consider improving these two points.
getting internal server error when deleting the testset |
closing this as, as agreed, we want to prevent deleting a testset instead of creating dummy one. |
Description
This PR achieves the following:
Related Issue
Closes #863 x #1005