-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement - Improve playground error message and introduce new CLI command for cloudwatch logs #984
Conversation
@bekossy, could you please check out this branch and help me run prettier on your PC to see if it prettifies the code? I'm not sure why it keeps failing, even after I've run the prettier command. If it prettifies the code, please commit and push. Thank you! |
It's all good now @aybruhm |
Thank you very much. What command did you run? |
|
Strange that it didn't work for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @aybruhm !
I think it makes sense to take create another error message for the cloud / ee version where these instructions don't make sense.
…eve variant function logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this feature.
I have two concerns
- It looks we need an api key when using oss version:
(agenta-py3.11) ➜ baby_name_generator git:(gh/issue-885-resolve) ✗ agenta get logs --variant 6579a2322a67587e518a690c
A new release of agenta is available: 0.5.4 → 0.6.2
To upgrade, run: pip install --upgrade agenta
Checking config file...
Retrieving variant logs...
API Key is not specified
- didn't we agree to use variant name instead of variant id ?
how users are supposed to find the variant id ?
Something like agenta get logs --file_name app_4.py Or way better than this is to ask the user to choose which variants' logs are requests (I recommend this option)
|
@aybruhm what is the status of this one? |
@aybruhm sure, let's have that discussion. |
Closing PR due to duplicate. |
Description
This PR accomplishes the following:
Work Done
Related Issue
Closes #885