-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLM Templates - Created vision_gpt_explain_image llm application #964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR @aybruhm !
I think there is one small confusion I see in the last examples and this one. The difference between configuration and input. For instance, in this case, the user is trying to create an llm application that compares different images. The configuration are the parameters they would iterate on in the playground to get a reliable app (let's say for comparing logo), these would include the temperature, max_tokens.. (https://platform.openai.com/docs/api-reference/chat/create), and models in case there are multiple options (in this case, I think there is only one model, so no need to include), and most importantly the prompt, since that is the main thing that they would play around with. On the other hand, the inputs for the application is the images (and not the prompt).
So first change, the system and user prompt are configuration. The images only are the inputs. Second change, we agreed yesterday that for now we will have the images in simple application and not in chat application, so no need for messages as an input.
Hope it's clear./
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @aybruhm
However I think the PR is tainted, lots of files that have nothing to do with it. Can you please clean it up?
I believe it's because the PR's base is |
Check again. I changed the PR's base to cc: @mmabrouk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @aybruhm
Just a small comment about the ag.init()
@aybruhm prettier is failing. Please make sure to use the same version we use in the workflow, I think that is the reason for the error |
@bekossy here also, thank you! |
@MohammedMaaz -> template for #944 |
Description
This PR introduces a new LLM application that utilizes Vision GPT to provide explanations for image(s).
Related Issue
Closes #953