Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM Templates - Created startup technical ideas LLM chat app #958

Merged
merged 21 commits into from
Nov 29, 2023

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Nov 28, 2023

Description

This PR introduces a new chat llm template that offers technical ideas to startups.

Related Issue

Closes #939

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you made a huge mistake. The model is a parameter in the configuration and not an input to the llm application!!!! That's why you needed making such changes!

@mmabrouk
Copy link
Member

Please see this example on how the application should be. Note that all the parameters from openai are part of the configuration (usually shown up in the playground)! Please let me know if it is not clear

@aybruhm aybruhm marked this pull request as draft November 28, 2023 16:37
@aybruhm aybruhm marked this pull request as ready for review November 28, 2023 21:21
@aybruhm
Copy link
Member Author

aybruhm commented Nov 28, 2023

Hi @devgenix, could you assist me in testing the creation of an app in OSS and in the cloud to verify if the templates are functioning on your end as well? Thank you.

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @aybruhm please see comments

examples/startup_technical_ideas/app.py Outdated Show resolved Hide resolved
examples/startup_technical_ideas/app.py Outdated Show resolved Hide resolved
examples/startup_technical_ideas/app.py Show resolved Hide resolved
@aybruhm aybruhm requested a review from mmabrouk November 29, 2023 14:33
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @aybruhm !
Could you please update the app in the templates too. Thanks!

@mmabrouk mmabrouk merged commit 35fe985 into main Nov 29, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create LLM app templates for Chat
2 participants