Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Add support for configurable Agenta Cloud URL in CLI #938

Merged
merged 11 commits into from
Nov 28, 2023

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Nov 27, 2023

Description

Currently, the CLI defaults to the cloud backend host when the cloud option is selected, which may not be desirable for all use cases. With this update, users can set the URL they want to use, enabling them to seamlessly switch between the various environment of Agenta as per their development needs.

To set the URL, run the command, agenta config set-host https://example.com.

Related Issue

Closes C_180

@aybruhm aybruhm requested a review from mmabrouk November 27, 2023 14:04
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you've implemented the logic to save the api keys to config but not to use it/ load it no?

I think we should not have the logic for saving, just for loading.

agenta-cli/agenta/cli/main.py Outdated Show resolved Hide resolved
@aybruhm
Copy link
Member Author

aybruhm commented Nov 27, 2023

It seems that you've implemented the logic to save the api keys to config but not to use it/ load it no?

I think we should not have the logic for saving, just for loading.

Api keys? No, I didn't.

@aybruhm aybruhm requested a review from mmabrouk November 27, 2023 14:16
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using the wrong config file in this PR (the local and not the global)!! The host should be in the global config file

@aybruhm
Copy link
Member Author

aybruhm commented Nov 27, 2023

You are using the wrong config file in this PR (the local and not the global)!! The host should be in the global config file

Alright, I'll adjust it to use the global config file. Thank you.

@aybruhm aybruhm requested a review from mmabrouk November 27, 2023 15:59
@mmabrouk mmabrouk requested a review from devgenix November 27, 2023 17:11
@mmabrouk mmabrouk assigned aybruhm and devgenix and unassigned aybruhm and devgenix Nov 27, 2023
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aybruhm !
Waiting for @devgenix to test and then I will merge.

Copy link
Contributor

@devgenix devgenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asides the review comment, I've tested it and it's all good.
Great work, @aybruhm

agenta-cli/agenta/cli/main.py Outdated Show resolved Hide resolved
@aybruhm aybruhm requested a review from devgenix November 28, 2023 06:34
Copy link
Contributor

@devgenix devgenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Good, thanks @aybruhm.

@mmabrouk mmabrouk merged commit 7ddda0e into main Nov 28, 2023
5 of 6 checks passed
@mmabrouk mmabrouk deleted the gh/implement-configurable-url-ac branch November 28, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants