-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug/Disable the submit button when the variable name field is empty - #576 #578
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ interface Props { | |
addTab: () => void | ||
variants: any[] | ||
setNewVariantName: (value: string) => void | ||
newVariantName: string | ||
setTemplateVariantName: (value: string) => void | ||
} | ||
|
||
|
@@ -26,26 +27,40 @@ const NewVariantModal: React.FC<Props> = ({ | |
addTab, | ||
variants, | ||
setNewVariantName, | ||
newVariantName, | ||
setTemplateVariantName, | ||
}) => { | ||
const classes = useStyles() | ||
const [variantPlaceHolder, setVariantPlaceHolder] = useState("Source Variant") | ||
const [isInputValid, setIsInputValid] = useState(false) // To check if the input is valid | ||
|
||
const handleTemplateVariantChange = (value: string) => { | ||
let newValue = value.includes(".") ? value.split(".")[0] : value | ||
setTemplateVariantName(value) | ||
setVariantPlaceHolder(`${newValue}`) | ||
setIsInputValid(newVariantName.trim().length > 0 && value !== "Source Variant") // Update the validity of the input | ||
} | ||
|
||
const handleInputChange = (e: React.ChangeEvent<HTMLInputElement>) => { | ||
const inputValue = e.target.value | ||
setNewVariantName(inputValue) | ||
setIsInputValid(inputValue.trim().length > 0 && variantPlaceHolder !== "Source Variant") // Update the validity of the input | ||
} | ||
|
||
return ( | ||
<Modal | ||
title="Create a New Variant" | ||
open={isModalOpen} | ||
onOk={() => { | ||
setIsModalOpen(false) | ||
addTab() | ||
if (isInputValid) { | ||
// Check if the input is valid | ||
setIsModalOpen(false) | ||
addTab() | ||
} | ||
}} | ||
onCancel={() => setIsModalOpen(false)} | ||
centered | ||
okButtonProps={{disabled: !isInputValid}} // Disable OK button if input is not valid | ||
> | ||
<Space direction="vertical" size={20}> | ||
<div> | ||
|
@@ -65,7 +80,7 @@ const NewVariantModal: React.FC<Props> = ({ | |
<Text>Enter a unique name for the new variant:</Text> | ||
<Input | ||
addonBefore={variantPlaceHolder} | ||
onChange={(e) => setNewVariantName(e.target.value)} | ||
onChange={handleInputChange} // Modify this line | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this comment might be not needed @yeokyeong-yanolja There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have removed this in a later commit. Thanks for noticing :) |
||
/> | ||
</div> | ||
</Space> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method name is too general. what input is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this context,
input
refers to the name of a variant. will make this clearer in the function name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may create an issue for it