Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restarting closed container from UI results in navigation to main page #559

Merged
merged 13 commits into from
Sep 11, 2023
Merged

Restarting closed container from UI results in navigation to main page #559

merged 13 commits into from
Sep 11, 2023

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Sep 8, 2023

issue #545

@bekossy
fixes refresh issue after restarting container
d2a74fc
@bekossy
removes setTimeout function
00df5d5
@bekossy
Merge branch 'Agenta-AI:main' into issue-545/restarting-closed-contai…
ec4ebdc 
…ner-results-in-navigation-to-apps
@bekossy
revert changes in axiosConfig
0872c63
@bekossy
Merge branch 'Agenta-AI:main' into issue-545/restarting-closed-contai…
56a2135 
…ner-results-in-navigation-to-apps
@bekossy
removes conditional
04436fe
@bekossy
Merge branch 'issue-545/restarting-closed-container-results-in-naviga…
dc74ea9 
…tion-to-apps' of https://github.com/bekossy/agenta into issue-545/restarting-closed-container-results-in-navigation-to-apps
@bekossy
Merge branch 'Agenta-AI:main' into issue-545/restarting-closed-contai…
4698811 
…ner-results-in-navigation-to-apps
@bekossy
Merge branch 'Agenta-AI:main' into issue-545/restarting-closed-contai…
674f986 
…ner-results-in-navigation-to-apps
mmabrouk
mmabrouk requested changes Sep 10, 2023
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bekossy for the PR! Please see the comment. Do we need to remove the useEffect at VariantRemovalWarningModal?

agenta-web/src/components/Playground/VariantRemovalWarningModal.tsx Show resolved Hide resolved
@bekossy
Copy link
Member Author

bekossy commented Sep 10, 2023

Thanks for the review @mmabrouk, I have made the requested changes.

@mmabrouk
Copy link
Member

Closes #545

mmabrouk
mmabrouk approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bekossy !

@mmabrouk mmabrouk merged commit 187660d into Agenta-AI:main Sep 11, 2023
@bekossy bekossy deleted the issue-545/restarting-closed-container-results-in-navigation-to-apps branch September 11, 2023 11:21
@bekossy bekossy mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekossy @mmabrouk