Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning in Testset about "Unsaved changes" without even adding any changes #548

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Sep 6, 2023

issue #507

@bekossy bekossy requested a review from aakrem September 6, 2023 09:34
@aakrem aakrem requested a review from MohammedMaaz September 6, 2023 16:08
@MohammedMaaz
Copy link
Contributor

@bekossy you have flipped the logic of the state variable loading with isChanged? Is there any particular reason for this? Can't we solve this issue without reworking the complete logic?

Copy link
Contributor

@MohammedMaaz MohammedMaaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aakrem aakrem merged commit d370200 into Agenta-AI:main Sep 11, 2023
3 checks passed
@bekossy bekossy deleted the issue-507/warning-in-testset-without-adding-any-changes branch September 11, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning in Testset about "Unsaved changes" without even adding any changes
3 participants