Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(frontend)[AGE 1478]: 404 page Displays on Page Refresh Within App View #2377

Merged
merged 4 commits into from
Dec 19, 2024
Merged

(frontend)[AGE 1478]: 404 page Displays on Page Refresh Within App View #2377

merged 4 commits into from
Dec 19, 2024

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Dec 16, 2024

Closes AGE-1478

@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 1:45pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 1:45pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working Frontend labels Dec 16, 2024
@bekossy bekossy requested a review from ardaerzin December 16, 2024 10:09
ardaerzin
ardaerzin approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@ardaerzin ardaerzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bekossy LGTM 👍

@bekossy bekossy changed the base branch from main to dev December 18, 2024 09:43
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 19, 2024
@ardaerzin ardaerzin merged commit 38b9fa6 into dev Dec 19, 2024
6 checks passed
@ardaerzin ardaerzin deleted the AGE-1478/-404-page-displays-on-page-refresh-within-app-view branch December 19, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardaerzin ardaerzin ardaerzin approved these changes

@mmabrouk mmabrouk Awaiting requested review from mmabrouk

Assignees
No one assigned
Labels
bug Something isn't working Frontend size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekossy @ardaerzin