Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(frontend)[AGE-1417]: Reduce effect of AgGrid on the initial bundle size #2363

Merged
merged 13 commits into from
Dec 18, 2024
Merged

(frontend)[AGE-1417]: Reduce effect of AgGrid on the initial bundle size #2363

merged 13 commits into from
Dec 18, 2024

Conversation

ardaerzin
Copy link
Contributor

@ardaerzin ardaerzin commented Dec 10, 2024 •
edited
Loading

closes AGE-1417

What has changed?

  • using ag-grid-community modules instead of packages
  • lazy module registration for additional functionality over core
  • new lazy importer we can use that'll register needed module

Test

  • components built on using AgGridReact, should not have regressed after these changes

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 11:22am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 11:22am

@mmabrouk mmabrouk changed the base branch from main to dev December 11, 2024 12:01
@ardaerzin ardaerzin marked this pull request as ready for review December 11, 2024 13:44
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Frontend labels Dec 11, 2024
@ashrafchowdury
Copy link
Collaborator

I did not know I could import packages this way, learned something unique today :)

Thank you for the PR @ardaerzin!

@bekossy bekossy self-requested a review December 13, 2024 10:14
@ardaerzin ardaerzin merged commit 835bc3e into dev Dec 18, 2024
5 of 6 checks passed
@ardaerzin ardaerzin deleted the AGE-1417/reduce-ag-grid-affect-on-bundle-size branch December 18, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bekossy bekossy Awaiting requested review from bekossy

Assignees
No one assigned
Labels
Frontend size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ardaerzin @ashrafchowdury